-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: fix flaky test br_txn #56444
base: master
Are you sure you want to change the base?
br: fix flaky test br_txn #56444
Conversation
Signed-off-by: Wenqi Mou <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @Tristan1900. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Wenqi Mou <[email protected]>
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #56444 +/- ##
================================================
+ Coverage 73.3645% 76.1302% +2.7656%
================================================
Files 1624 1624
Lines 448069 448152 +83
================================================
+ Hits 328724 341179 +12455
+ Misses 99207 85973 -13234
- Partials 20138 21000 +862
Flags with carried forward coverage won't be shown. Click here to find out more.
|
What problem does this PR solve?
Issue Number: close #54979
Problem Summary:
What changed and how does it work?
Feels like the way of generating load might have a race condition with the test setup. We noticed a mismatch of number of items before and after restore causing checksum mismatch.
This PR changes the code to generate a fixed number of items and run locally several times and cannot reproduce the issue anymore.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.