Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: handle lock and unlock operations correctly #56454

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Rustin170506
Copy link
Member

What problem does this PR solve?

Issue Number: ref #55906

Problem Summary:

What changed and how does it work?

This PR is based on #56437

Handle the lock and unlock operations correctly.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

fix: do not maintain time window in the queue

refactor: make lint happy

docs: add FIXME

refactor: rename to rebuildWithoutLock

fix

docs: add more comments

fix

fix

fix

fix

fix

fix

fix

fix

feat: add jobHooks

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix
fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix
fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner labels Oct 5, 2024
Copy link

ti-chi-bot bot commented Oct 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from rustin170506 and additionally assign d3hunter for approval(Please ensuring that each of them provides their approval before proceeding). For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 5, 2024
Copy link

codecov bot commented Oct 5, 2024

Codecov Report

Attention: Patch coverage is 63.27044% with 292 lines in your changes missing coverage. Please review.

Project coverage is 75.3543%. Comparing base (74034d4) to head (602f8ef).

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #56454        +/-   ##
================================================
+ Coverage   73.3645%   75.3543%   +1.9897%     
================================================
  Files          1624       1647        +23     
  Lines        448069     456677      +8608     
================================================
+ Hits         328724     344126     +15402     
+ Misses        99207      91253      -7954     
- Partials      20138      21298      +1160     
Flag Coverage Δ
integration 50.2229% <2.7673%> (?)
unit 72.5053% <63.2704%> (+0.0416%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 52.3088% <ø> (+6.7957%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant