Merge pull request #84 from planetscale/bigint-tinyint-changes

Support `tinyint(1) unsigned` for `boolean` conversion
planetscale · Oct 17, 2023 · d23b75a · d23b75a
2 parents 714ac3f + 004b34a
commit d23b75a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/cmd/internal/planetscale_edge_database.go b/cmd/internal/planetscale_edge_database.go
@@ -144,7 +144,7 @@ func getJsonSchemaType(mysqlType string, treatTinyIntAsBoolean bool) PropertyTyp
 		return PropertyType{Type: "string", CustomFormat: "date-time", AirbyteType: "timestamp_without_timezone"}
 	}
 
-	if mysqlType == "tinyint(1)" {
+	if strings.HasPrefix(mysqlType, "tinyint(1)") {
 		if treatTinyIntAsBoolean {
 			return PropertyType{Type: "boolean"}
 		}

diff --git a/cmd/internal/planetscale_edge_database_test.go b/cmd/internal/planetscale_edge_database_test.go
@@ -219,12 +219,24 @@ func TestDiscover_CanPickRightAirbyteType(t *testing.T) {
 			AirbyteType:           "",
 			TreatTinyIntAsBoolean: true,
 		},
+		{
+			MysqlType:             "tinyint(1) unsigned",
+			JSONSchemaType:        "boolean",
+			AirbyteType:           "",
+			TreatTinyIntAsBoolean: true,
+		},
 		{
 			MysqlType:             "tinyint(1)",
 			JSONSchemaType:        "integer",
 			AirbyteType:           "",
 			TreatTinyIntAsBoolean: false,
 		},
+		{
+			MysqlType:             "tinyint(1) unsigned",
+			JSONSchemaType:        "integer",
+			AirbyteType:           "",
+			TreatTinyIntAsBoolean: false,
+		},
 		{
 			MysqlType:      "bigint(16)",
 			JSONSchemaType: "string",