Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation #127

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Update documentation #127

merged 2 commits into from
Jul 11, 2024

Conversation

terryyanko
Copy link
Contributor

The current docs fail to mention the automatic token mapping already added to the current version of the template which risks wasting people's time configuring mappings manually. Additionally, the current docs suggest Node 14x is a requirement which it is not. This has been tested with at minimum, Node 16.x and 18.x.

Copy link
Member

@mjeffryes mjeffryes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for suggesting these updates. I have a few tweaks to the wording, but agree we should make these corrections!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
- match the nodejs supported versions
- suggest skipping to make provider rather than skipping the whole section.
@mjeffryes mjeffryes enabled auto-merge (squash) July 11, 2024 22:59
@mjeffryes mjeffryes merged commit 16417c6 into pulumi:main Jul 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants