Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved string styling #344

Merged
merged 6 commits into from
Jul 19, 2023
Merged

Improved string styling #344

merged 6 commits into from
Jul 19, 2023

Conversation

trag1c
Copy link
Member

@trag1c trag1c commented Jul 19, 2023

  • Made f-strings use outer double quotes when doing interpolation (probably ignored by a formatter), e.g. 
    -f' It must be one of {", ".join(self.COLORS.keys())}'
+f" It must be one of {', '.join(self.COLORS.keys())}"
  • Flipped quotes for a raw string using both inside: 
    -r'a\'"z'
+r"a'\"z"
  • Made all RegEx strings raw strings, e.g. 
    -"(?i)^y"
+r"(?i)^y"

@Secrus Secrus added the skip news Skip the check for a news file label Jul 19, 2023
@Secrus Secrus self-assigned this Jul 19, 2023
@Secrus
Copy link
Member

Secrus commented Jul 19, 2023

Please remove the news entry, the changes here are purely cosmetic and not user-facing.

@Secrus Secrus merged commit c602151 into python-poetry:main Jul 19, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Secrus Secrus Secrus approved these changes

Assignees

@Secrus Secrus

Labels
skip news Skip the check for a news file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trag1c @Secrus