Fix space cadet auto shift interaction

[AndrewMoscoe]

Fix for this bug: #20978

Enable space cadet shift - left shift (, right shift )
Enable auto shift

Press shift, press a letter, and release shift before releasing the letter.

When using left shift, the ( will be before the letter. When using right shift, the ) will be after the letter.

If you release shift after releasing the letter, the () will not print, and the keyboard works as you would want.

Description

Fix space cadet-auto shift interaction bug

Types of Changes

• Core
• Bugfix
• New feature
• Enhancement/optimization
• Keyboard (addition or update)
• Keymap/layout (addition or update)
• Documentation

Issues Fixed or Closed by This PR

• Fixes [Bug] Space Cadet Shift and Auto Shift interaction produces unwanted () characters #20978

Checklist

• [x ] My code follows the code style of this project: C, Python
• [ x] I have read the PR Checklist document and have made the appropriate changes.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[drashna]

Could you (please) add to the unit tests, as well? They are there to help ensure that behavior is consistent and as expected, especially when things change.

[AndrewMoscoe]

Could you (please) add to the unit tests, as well? They are there to help ensure that behavior is consistent and as expected, especially when things change.

I added it, but the CI job says "This workflow is awaiting approval from a maintainer"

[IsaacElenbaas]

Just wanted to link #24341 - you might run into it since you're also using physical shift keys.

[drashna]

Could you (please) add to the unit tests, as well? They are there to help ensure that behavior is consistent and as expected, especially when things change.

I added it, but the CI job says "This workflow is awaiting approval from a maintainer"

"first time contributor", github security thing. It can take a bit before approval is given.
s
That said, you can run the tests locally. Either with qmk test-c -t auto_shift or make test:autoshift

[drashna]

Lint wants: