[Enhancement] Strip paths from metadata comments #24456
Open
+33
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per @sigprof and @tzarc discussion on discord a few weeks ago
NOTE: Does still show "fake" arguments, like
--flag False
(user would have used just--flag
)However, i dont think there is a great way of handling it... We may use
sys.argv[1:]
or the like, but that would lose some extra context/information, such as the parsing (default values? type casting?) performed bymilc
, while the current approach does show relevant info: what the code "sees"... Im open to other alternatives about this, anywayTypes of Changes
Issues Fixed or Closed by This PR
Checklist