Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create skyloong gk87 backlight keyboard #24460

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

NaturalZh
Copy link

Skyloong GK87 Backlight Keyboard

Description

Skyloong GK87 Backlight Keyboard is a LED backlight keyboard. There are three encoders on the top-right.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@waffle87
Copy link
Member

waffle87 commented Oct 7, 2024

This appears to be a wireless keyboard, as per the provided store listing page.

@vbrabandt2005
Copy link

vbrabandt2005 commented Oct 7, 2024

Sorry to interrupt, I'm not associated with any party (though I do have this exact keyboard on pre-order)

@waffle87 I believe you have got the wrong keyboard, The keyboard that @NaturalZh wants to add is this Skyloong GK87 model (It's an Epomaker link but it's the same skyloong board).

This model is wired only so it shouldn't require wireless-code.

@NaturalZh also included a link to an image of this exact board in the README.md they had written.

@NaturalZh
Copy link
Author

Sorry to interrupt, I'm not associated with any party (though I do have this exact keyboard on pre-order)

@waffle87 I believe you have got the wrong keyboard, The keyboard that @NaturalZh wants to add is this Skyloong GK87 model (It's an Epomaker link but it's the same skyloong board).

This model is wired only so it shouldn't require wireless-code.

@NaturalZh also included a link to an image of this exact board in the README.md they had written.

Yes, you are right. I updated the readme.md. Thank you very much.

@NaturalZh
Copy link
Author

This appears to be a wireless keyboard, as per the provided store listing page.

I'm very sorry for the trouble. I have updated the readme.md. Thank you.

@NaturalZh
Copy link
Author

Would you please review this pull request again? @waffle87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants