Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Add S6xty PCB #24465

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

[Keyboard] Add S6xty PCB #24465

wants to merge 16 commits into from
+635 −0

Conversation

trnthsn
Copy link
Contributor

@trnthsn trnthsn commented Oct 9, 2024 •
edited
Loading

Description

Add QMK support for S6xty PCB

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

This was referenced Oct 9, 2024
Open
Open
dunk2k
dunk2k suggested changes Oct 9, 2024
View reviewed changes
keyboards/trnthsn/s6xty/halconf.h Outdated Show resolved Hide resolved
keyboards/trnthsn/s6xty/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/trnthsn/s6xty/keyboard.json Outdated Show resolved Hide resolved
keyboards/trnthsn/s6xty/keymaps/default/keymap.c Outdated Show resolved Hide resolved
dunk2k
dunk2k suggested changes Oct 9, 2024
View reviewed changes
keyboards/trnthsn/s6xty/keyboard.json
Copy link
Contributor

@dunk2k dunk2k Oct 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can qmk format-json -i be run on this file? as tab characters to be replaced with 4 spaces

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i updated keyboard.json

trnthsn and others added 2 commits October 9, 2024 17:24
dunk2k
dunk2k suggested changes Oct 9, 2024
View reviewed changes
keyboards/trnthsn/s6xty/readme.md Outdated

![trnthsn/s6xty](https://i.imgur.com/YJZxxqY.png)

*A short description of the keyboard/project*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could a short description of the keyboard/PCB be placed here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i has pushed a new commit to add a description here

@waffle87 waffle87 requested a review from a team October 9, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waffle87 waffle87 waffle87 approved these changes

@dunk2k dunk2k dunk2k approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trnthsn @waffle87 @dunk2k