Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSockets Next: activate CDI request context only if needed #43915

Merged
merged 1 commit into from
Oct 16, 2024
Merged

WebSockets Next: activate CDI request context only if needed #43915

merged 1 commit into from
Oct 16, 2024
+416 −23

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Oct 16, 2024

@mkouba
Copy link
Contributor Author

mkouba commented Oct 16, 2024

FYI @franz1981

cescoffier
cescoffier approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - wondering what happens if I use @ActivateRequestScope.

docs/src/main/asciidoc/websockets-next-reference.adoc Show resolved Hide resolved
franz1981
franz1981 approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@franz1981 franz1981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one @mkouba good idea! Activating it is indeed pretty costly!

@quarkus-bot

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2024 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@quarkus-bot

This comment has been minimized.

Sign in to view
@mkouba mkouba force-pushed the ws-next-request-context-optimization branch from 744238e to 38147c1 Compare October 16, 2024 14:44
@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 16, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 16, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 38147c1.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

You can consult the Develocity build scans.

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 16, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 38147c1.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gsmet gsmet merged commit 13d48dd into quarkusio:main Oct 16, 2024
23 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 16, 2024
@quarkus-bot quarkus-bot bot added this to the 3.17 - main milestone Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

@franz1981 franz1981 franz1981 approved these changes

@michalvavrik michalvavrik michalvavrik approved these changes

Assignees
No one assigned
Labels
area/documentation
Projects
None yet
Milestone
3.17 - main
Development

Successfully merging this pull request may close these issues.
5 participants
@mkouba @cescoffier @franz1981 @michalvavrik @gsmet