Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Debug implementations. #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

reitermarkus
Copy link
Contributor

@reitermarkus reitermarkus commented May 31, 2022

Regarding #65 (comment), I'm generally in favour of debuggability over compile time since this seems like a micro-optimization at this scale.

I mainly needed this while debugging this crate itself, but I still think having Debug for all public items in a crate is useful.

@reitermarkus reitermarkus mentioned this pull request May 31, 2022
Copy link
Owner

@rafalh rafalh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some tests on my local system and I could not find a noticeable change in compile time (release build) or executable size (examples from this repo) so I am willing to merge it. But I'd like to see an explanation for MSRV change

@@ -15,7 +15,7 @@ jobs:
- rust_version: nightly
run_tests: true
# Minimal supported rustc version
- rust_version: 1.46.0
- rust_version: 1.47.0
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why change to MSRV?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deriving Debug for fixed-sized arrays needs 1.47.

Copy link
Contributor Author

@reitermarkus reitermarkus Nov 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specifically the big [u8; 448] array in BootSector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants