-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing Debug
implementations.
#67
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some tests on my local system and I could not find a noticeable change in compile time (release build) or executable size (examples from this repo) so I am willing to merge it. But I'd like to see an explanation for MSRV change
@@ -15,7 +15,7 @@ jobs: | |||
- rust_version: nightly | |||
run_tests: true | |||
# Minimal supported rustc version | |||
- rust_version: 1.46.0 | |||
- rust_version: 1.47.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why change to MSRV?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deriving Debug
for fixed-sized arrays needs 1.47.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specifically the big [u8; 448]
array in BootSector
.
Regarding #65 (comment), I'm generally in favour of debuggability over compile time since this seems like a micro-optimization at this scale.
I mainly needed this while debugging this crate itself, but I still think having
Debug
for all public items in a crate is useful.