Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci][microcheck] add macos + windows tests to microcheck #45361

Merged
merged 2 commits into from
May 16, 2024
Merged

Conversation

can-anyscale
Copy link
Collaborator

Add macos + window tests to microcheck

Test:

  • CI

@can-anyscale can-anyscale requested review from a team, aslonnie and khluu May 15, 2024 20:01
Copy link
Collaborator

@aslonnie aslonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do people ask for this? need this?

like if it is microcheck, probably very unlikely for someone to click the unblock button?

@can-anyscale
Copy link
Collaborator Author

i cut a task for @zcin to debug some flaky tests on windows ;); she didn't ask for this but thinking about doing this before she even asks

also #45278 is another release blocker windows test still under debugging

core team debugs macos tests on PR a lot as well

…overage (#45362)

Add an options to consider master branch test results for microcheck
coverage. This is specifically for windows + macos tests since they do
not run on PRs.

Currently we'll consider any non-flaky tests (evaluated based on the
number of consecutive failures) on master branch.

Test:
- CI

---------

Signed-off-by: can <[email protected]>
@can-anyscale can-anyscale enabled auto-merge (squash) May 16, 2024 01:36
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label May 16, 2024
@can-anyscale can-anyscale merged commit 83b3893 into master May 16, 2024
8 checks passed
@can-anyscale can-anyscale deleted the can-mcx01 branch May 16, 2024 02:29
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Jun 6, 2024
…#45361)

Add macos + window tests to microcheck

Test:
- CI

---------

Signed-off-by: can <[email protected]>
Signed-off-by: Ryan O'Leary <[email protected]>
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Jun 6, 2024
…#45361)

Add macos + window tests to microcheck

Test:
- CI

---------

Signed-off-by: can <[email protected]>
Signed-off-by: Ryan O'Leary <[email protected]>
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Jun 7, 2024
…#45361)

Add macos + window tests to microcheck

Test:
- CI

---------

Signed-off-by: can <[email protected]>
GabeChurch pushed a commit to GabeChurch/ray that referenced this pull request Jun 11, 2024
…#45361)

Add macos + window tests to microcheck

Test:
- CI

---------

Signed-off-by: can <[email protected]>
Signed-off-by: gchurch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants