-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci][microcheck] add macos + windows tests to microcheck #45361
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: can <[email protected]>
aslonnie
approved these changes
May 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do people ask for this? need this?
like if it is microcheck, probably very unlikely for someone to click the unblock button?
…overage (#45362) Add an options to consider master branch test results for microcheck coverage. This is specifically for windows + macos tests since they do not run on PRs. Currently we'll consider any non-flaky tests (evaluated based on the number of consecutive failures) on master branch. Test: - CI --------- Signed-off-by: can <[email protected]>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 6, 2024
…#45361) Add macos + window tests to microcheck Test: - CI --------- Signed-off-by: can <[email protected]> Signed-off-by: Ryan O'Leary <[email protected]>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 6, 2024
…#45361) Add macos + window tests to microcheck Test: - CI --------- Signed-off-by: can <[email protected]> Signed-off-by: Ryan O'Leary <[email protected]>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 7, 2024
…#45361) Add macos + window tests to microcheck Test: - CI --------- Signed-off-by: can <[email protected]>
GabeChurch
pushed a commit
to GabeChurch/ray
that referenced
this pull request
Jun 11, 2024
…#45361) Add macos + window tests to microcheck Test: - CI --------- Signed-off-by: can <[email protected]> Signed-off-by: gchurch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add macos + window tests to microcheck
Test: