[ci][microcheck] use commit instead of branch for failed prs #45384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can-anyscale
changed the title
aslonnie
reviewed
May 16, 2024
| stub_test_result(ResultStatus.ERROR, "w00t"), | ||
| stub_test_result(ResultStatus.SUCCESS, "hi"), | ||
| stub_test_result(ResultStatus.ERROR, "f00"), | ||
| stub_test_result(ResultStatus.ERROR, "w00t", commit="w00t.v1"), |
There was a problem hiding this comment.
why the commit looks like "woot.v1" here? does not really look like a commit?
Comment on lines
+146
to
+148
| Get the failed PRs for a test. We use the commit to account for all revisions | ||
| of a PR. |
There was a problem hiding this comment.
this is not returning set of "PRs" any more? should we change it to _get_failed_runs or _get_failed_commits?
Signed-off-by: can <[email protected]>
|
update the function names from |
aslonnie
approved these changes
May 16, 2024
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 6, 2024
…ject#45384) Use commit instead of branch to identify failed prs, to account for all PR revisions. We seems to be under-coverage in large PRs where people make several bugs across multiple PR revisions. Test: - CI Signed-off-by: can <[email protected]> Signed-off-by: Ryan O'Leary <[email protected]>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 6, 2024
…ject#45384) Use commit instead of branch to identify failed prs, to account for all PR revisions. We seems to be under-coverage in large PRs where people make several bugs across multiple PR revisions. Test: - CI Signed-off-by: can <[email protected]> Signed-off-by: Ryan O'Leary <[email protected]>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 7, 2024
…ject#45384) Use commit instead of branch to identify failed prs, to account for all PR revisions. We seems to be under-coverage in large PRs where people make several bugs across multiple PR revisions. Test: - CI Signed-off-by: can <[email protected]>
GabeChurch
pushed a commit
to GabeChurch/ray
that referenced
this pull request
Jun 11, 2024
…ject#45384) Use commit instead of branch to identify failed prs, to account for all PR revisions. We seems to be under-coverage in large PRs where people make several bugs across multiple PR revisions. Test: - CI Signed-off-by: can <[email protected]> Signed-off-by: gchurch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use commit instead of branch to identify failed prs, to account for all PR revisions. We seems to be under-coverage in large PRs where people make several bugs across multiple PR revisions.
Test: