[Core] Fix check failure: sync_reactors_.find(reactor->GetRemoteNodeID()) == sync_reactors_.end() #47861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sync_reactors_.end() Signed-off-by: Jiajun Yao <[email protected]>
Signed-off-by: Jiajun Yao <[email protected]>
Signed-off-by: Jiajun Yao <[email protected]>
Signed-off-by: Jiajun Yao <[email protected]>
Signed-off-by: Jiajun Yao <[email protected]>
Signed-off-by: Jiajun Yao <[email protected]>
Signed-off-by: Jiajun Yao <[email protected]>
Signed-off-by: Jiajun Yao <[email protected]>
Signed-off-by: Jiajun Yao <[email protected]>
rkooo567
approved these changes
Oct 4, 2024
| @@ -124,6 +125,77 @@ def check_task_pending(n=0): | |||
| wait_for_condition(lambda: check_task_pending(2)) | |||
|
|
|||
|
|
|||
| head2 = gen_head_node( | |||
There was a problem hiding this comment.
this test seems very useful. wonder if we should extend it to more e2e tests in some stress tests?
There was a problem hiding this comment.
Yea, I'll use the same pattern for other tests. I'm also exploring chaos test tools for randomly injecting network errors.
| // Disconnect exiting connection if there is any. | ||
| // This can happen when there is transient network error | ||
| // and the client reconnects. | ||
| syncer_.Disconnect(reactor->GetRemoteNodeID()); |
There was a problem hiding this comment.
QQ: why don't we call this in clean_cb?
There was a problem hiding this comment.
syncer_.Disconnect triggers the call of cleanup_cb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The sequence of events that triggers this check failure is
RayClientBidiReactor::OnDoneis called with non-ok grpc status.cleanup_cb_ofRayClientBidiReactoris called which reconnects to the head node.RaySyncerService::StartSyncto be called.RaySyncer::Connectis called with a newRayServerBidiReactor.RayServerBidiReactorfrom the worker node's previous connection, the check fails.This PR fixes the issue by disconnecting the old
RayServerBidiReactorfirst before adding a new one.Related issue number
Closes #45639
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.