Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add terms related to ELB #593

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Jul 28, 2023

Add Elastic Load Balancing (ELB) references that were recently merged into the SSG repository: https://redhat-documentation.github.io/supplementary-style-guide/#elb

PR: redhat-documentation/supplementary-style-guide#363

@github-actions
Copy link

github-actions bot commented Jul 28, 2023

🎊 Navigate the preview: https://redhat-documentation-vale-at-red-hat-593.surge.sh 🎊

@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@dfitzmau dfitzmau changed the title Add terms releated to ELB Add terms related to ELB Jul 28, 2023
@aireilly
Copy link
Member

This is not quite correct :) What you've done here is add the correct terms that you want to see to the Usage rule that flags error terms.

What you need to do for these new terms is to the following exact string to TermsErrors.yml:

Elastic Load Balancer: Elastic Load Balancing this pair is in the form "bad: good". the bad term is what gets highlighted by Vale as an error. You also need to add these good and bad terms to the fixtures folder, under /TermsErrors to the appropriate fixture file.

@dfitzmau dfitzmau force-pushed the elb-references branch 2 times, most recently from 15c618c to d2206a2 Compare July 31, 2023 09:44
@dfitzmau
Copy link
Contributor Author

This is not quite correct :) What you've done here is add the correct terms that you want to see to the Usage rule that flags error terms.

What you need to do for these new terms is to the following exact string to TermsErrors.yml:

Elastic Load Balancer: Elastic Load Balancing this pair is in the form "bad: good". the bad term is what gets highlighted by Vale as an error. You also need to add these good and bad terms to the fixtures folder, under /TermsErrors to the appropriate fixture file.

Thanks. I updated the TermErrors > testinvalid and testvalid files. They're not showing up on the Files changed tab and I have no local files in my working or staged area. Maybe these are hidden files?

@aireilly
Copy link
Member

/lgtm

@dfitzmau dfitzmau force-pushed the elb-references branch 2 times, most recently from 1558b91 to 6d1cbe7 Compare August 1, 2023 11:32
@aireilly aireilly merged commit 15aaf51 into redhat-documentation:main Aug 9, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants