Add new params and full hiera support #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
Bugfix hash merge
|
fixed up rspec tests for older puppet versions |
|
Hihi @rodjek, any chance you'll merge these changes? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds 3 new params and full Hiera support.
$packages which allows overriding the package list
$rules which allows specifying a hash of logrotate rules
$hieramerge which allows hiera hash merging of logrotate rules
I've also updated the rspec tests and cleaned up the code some for a bit more standard behavior (init.pp).
This SHOULD be backwards compatible with existing usage.
Please see updated documentation for new feature usage.