fix(pluginutils): optimize createFilter and normalizePath
#1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shellscape
changed the title
createFilter and normalizePathcreateFilter and normalizePath
shellscape
requested changes
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
{pluginutils}This PR contains:
Are tests included?
Breaking Changes?
Description
createFilterandnormalizePathare on the hot path. This PR tries to improve their performance.Simple benchmarks (may not be very accurate, but IMO the direction is right):
filename.split(win32.sep).join(posix.sep)->filename.replace(/\\/g, '/')- jsbenchmark.comAlso, this PR hard-coded
win32.sepandposix.sep. This is because this is faster, and the behavior ofnormalizePathshould not change even when one day Windows starts to use/as the path separator./\0/.test(id)->id.includes('\0')- jsbenchmark.comAlso, this PR creates a fast path for empty filters - Usually
createFilterstakes paths from plugins' options, which defaults to empty if not specified.