OpenNI2 pkg_config replaced with find script from PCL.

[ahundt]

Compilation now works on OS X and should generally be more cross platform

[130s]

@ahundt There's a merge conflict. Would you mind rebasing to the origin/indigo-devel?

[ahundt]

@130s fixed it, considering I opened this in 2016-08, hopefully it can be merged before 2019. :-)

[130s]

Thanks, let's see if we can push by the end of 2017!

All CI jobs failed with errors like the following. Do you think you can take time at this and add fixes if necessary?

https://travis-ci.org/ros-drivers/openni2_camera/jobs/296609885#L676

Starting  >>> openni2_camera                      
_______________________________________________________________________________
Errors     << openni2_camera:make /root/catkin_ws/logs/openni2_camera/build.make.000.log
/root/catkin_ws/src/openni2_camera/src/openni2_device.cpp:32:24: fatal error: ni2/OpenNI.h: No such file or directory
 #include "ni2/OpenNI.h"
                        ^
compilation terminated.
/root/catkin_ws/src/openni2_camera/src/openni2_frame_listener.cpp:31:24: fatal error: ni2/OpenNI.h: No such file or directory
 #include "ni2/OpenNI.h"
                        ^
compilation terminated.
In file included from /root/catkin_ws/src/openni2_camera/src/openni2_timer_filter.cpp:32:0:
/root/catkin_ws/src/openni2_camera/include/openni2_camera/openni2_timer_filter.h:37:24: fatal error: ni2/OpenNI.h: No such file or directory
 #include "ni2/OpenNI.h"
                        ^
compilation terminated.
make[2]: *** [CMakeFiles/openni2_wrapper.dir/src/openni2_device.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: *** [CMakeFiles/openni2_wrapper.dir/src/openni2_frame_listener.cpp.o] Error 1
In file included from /root/catkin_ws/src/openni2_camera/src/openni2_convert.cpp:32:0:
/root/catkin_ws/src/openni2_camera/include/openni2_camera/openni2_convert.h:39:24: fatal error: ni2/OpenNI.h: No such file or directory
 #include "ni2/OpenNI.h"
                        ^
compilation terminated.
make[2]: *** [CMakeFiles/openni2_wrapper.dir/src/openni2_timer_filter.cpp.o] Error 1
make[2]: *** [CMakeFiles/openni2_wrapper.dir/src/openni2_convert.cpp.o] Error 1
In file included from /root/catkin_ws/src/openni2_camera/src/openni2_device_manager.cpp:33:0:
/root/catkin_ws/src/openni2_camera/include/openni2_camera/openni2_convert.h:39:24: fatal error: ni2/OpenNI.h: No such file or directory
 #include "ni2/OpenNI.h"
                        ^
compilation terminated.
make[2]: *** [CMakeFiles/openni2_wrapper.dir/src/openni2_device_manager.cpp.o] Error 1
make[1]: *** [CMakeFiles/openni2_wrapper.dir/all] Error 2
make: *** [all] Error 2
cd /root/catkin_ws/build/openni2_camera; catkin build --get-env openni2_camera | catkin env -si  /usr/bin/make --jobserver-fds=6,7 -j; cd -
...............................................................................
Failed     << openni2_camera:make                  [ Exited with code 2 ]
Failed    <<< openni2_camera                       [ 3.3 seconds ]
[build] No packages succeded.

[ahundt]

Hmm, where does openni2 get installed in this? If it is simply at an unexpected path adding it should be simple. Would you mind adding a brief readme on master with a travis status link as well so I can figure this out again? :-)

[MatthijsBurgh]

Let's close this one.

[130s]

Let's close this one.

@MatthijsBurgh Do you remember if you meant to "merge" or "close without merging"? Just clarifying.

[MatthijsBurgh]

@130s I think I wanted to close back then. But now I have a second look at it, we can forward with this.

We should update the find script with the most current version from PCL, https://github.com/PointCloudLibrary/pcl/blob/master/cmake/Modules/FindOpenNI2.cmake.

And set(CMAKE_MODULE_PATH ${CMAKE_CURRENT_SOURCE_DIR}/cmake) should be a list append IMO, so list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake")