Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed logic exception if auto convert is disabled #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xarem
Copy link

@xarem xarem commented Dec 3, 2023

on some controllers, an LogicException is thrown although auto convert is disabled. This fixed it as it should not trigger

@roukmoute
Copy link
Owner

roukmoute commented Dec 3, 2023

Hey and thanks!

But is it possible to have a concrete example?

Because currently there is a test for that named it_throws_when_force_hash_variable_in_request_and_auto_convert_is_deactivated.

So I can't currently accept your P.R. during the test is invalid.

P.S.: doesn't take into account php-cs-fixer, which makes modifications that are not backward-compatible, so it often causes problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants