2358-2 #266

bigbrother13 · 2018-07-21T00:51:53Z

Номер

2358

Номер задания

2

Ссылка на видео с демо

Metrics/AbcSize: Assignment Branch Condition size for calculation is too high. [40.94/15]
Metrics/CyclomaticComplexity: Cyclomatic complexity for calculation is too high. [7/6]
Metrics/MethodLength: Method has too many lines. [31/10]
Metrics/PerceivedComplexity: Perceived complexity for calculation is too high. [10/7]

houndci-bot · 2018-07-24T22:32:43Z

2358/2/index.rb

+
+      words_from_text = lines.join.tr("\n", ' ').delete('.,;').split
+
+      bad_words_count = words_from_text.select do |x|


UncommunicativeVariableName: TextHandler#calculation has the variable name 'x'. More info.

houndci-bot · 2018-07-24T22:32:43Z

2358/2/index.rb

+    end
+  end
+
+  def show_table


TooManyStatements: TextHandler#show_table has approx 6 statements. More info.

houndci-bot · 2018-07-24T22:32:43Z

2358/2/index.rb

+
+  private
+
+  def calculation


TooManyStatements: TextHandler#calculation has approx 20 statements. More info.

houndci-bot · 2018-07-24T22:32:43Z

2358/2/index.rb

+require 'terminal-table'
+require_relative 'constants'
+
+class TextHandler


TooManyInstanceVariables: TextHandler has at least 6 instance variables. More info.

houndci-bot · 2018-07-24T22:32:43Z

2358/2/index.rb

+
+      name_from_hash = RAPPER_NAMES.find { |_, reg| rapper_name =~ reg }
+
+      next if name_from_hash.nil?


NilCheck: TextHandler#calculation performs a nil-check. More info.

houndci-bot · 2018-07-24T22:32:43Z

2358/2/index.rb

+      next if file =~ /^\./
+      rapper_name = file.split(/ против | VS | vs /)[0].split.join(' ')
+
+      name_from_hash = RAPPER_NAMES.find { |_, reg| rapper_name =~ reg }


NestedIterators: TextHandler#calculation contains iterators nested 2 deep. More info.

houndci-bot · 2018-07-25T22:34:31Z

2358/2/index.rb

+end
+
+
+


Layout/EmptyLines: Extra blank line detected.

houndci-bot · 2018-07-25T22:34:31Z

2358/2/index.rb

+  end
+end
+
+


Layout/EmptyLines: Extra blank line detected.

houndci-bot · 2018-07-25T22:34:31Z

2358/2/index.rb

+      end
+    else
+      puts "Рэпер #{@name} не известен мне. Зато мне известны:"
+      RAPPER_NAMES.keys.shuffle.first(5).each { |name| puts "#{name}\n" }


Performance/Sample: Use sample(5) instead of shuffle.first(5).

houndci-bot · 2018-07-25T22:34:31Z

2358/2/index.rb

+  def show_favorite_word
+    if RAPPER_NAMES[@name]
+      counter_array = (@words_counter[@name] - SHORT_WORDS).group_by { |name| name }.map { |name, counter| [name, counter.count] }
+      list_of_words = Hash[counter_array].sort_by {|_, counter| counter }.reverse


Layout/SpaceInsideBlockBraces: Space between { and | missing.

houndci-bot · 2018-07-25T22:34:32Z

2358/2/index.rb

+
+  def show_favorite_word
+    if RAPPER_NAMES[@name]
+      counter_array = (@words_counter[@name] - SHORT_WORDS).group_by { |name| name }.map { |name, counter| [name, counter.count] }


Metrics/LineLength: Line is too long. [130/120]

houndci-bot · 2018-07-25T22:34:32Z

2358/2/index.rb

+  end
+  # rubocop:enable Metrics/MethodLength
+
+  def show_favorite_word


Metrics/AbcSize: Assignment Branch Condition size for show_favorite_word is too high. [20.12/15]

houndci-bot · 2018-07-25T22:34:32Z

2358/2/index.rb

+  # :reek:NilCheck
+  # :reek:NestedIterators
+  def calculation
+    Dir.new(TEXTS_PATH).each do |file|


Metrics/BlockLength: Block has too many lines. [30/25]

houndci-bot · 2018-07-25T22:34:32Z

2358/2/index.rb

+  end
+  # rubocop:enable Metrics/MethodLength
+
+  def show_favorite_word


TooManyStatements: TextHandler#show_favorite_word has approx 10 statements. More info.

houndci-bot · 2018-07-25T22:34:32Z

2358/2/index.rb

+
+  def show_result
+    calculation
+    if @name.nil?


NilCheck: TextHandler#show_result performs a nil-check. More info.

houndci-bot · 2018-07-25T22:34:32Z

2358/2/constants.rb

@@ -0,0 +1,111 @@
+TEXTS_PATH = "#{Dir.pwd}/texts".freeze
+SHORT_WORDS = %w[в на и я с не ни по под от у ты что Я И ТЫ как это Но - тебя но меня он А мне за все бы был кто так же его то Это тебе Ты а про вы мой Он тут Что  из есть у здесь нет Как к Если Не там даже Вы для Ты ф про вы мой Он тут Что из у Как к Не там Вы где для  В до всё мы или – У То *** раз Вот Мы еще со их Ну о без].freeze


Metrics/LineLength: Line is too long. [335/120]
Layout/SpaceInsideArrayPercentLiteral: Use only a single space inside array percent literal.

houndci-bot · 2018-07-26T12:19:21Z

2358/2/index.rb

+    )
+    puts table
+  end
+ # rubocop:disable Metrics/LineLength


Lint/UnneededCopDisableDirective: Unnecessary disabling of Metrics/LineLength.

houndci-bot · 2018-07-26T12:19:21Z

2358/2/index.rb

+  # rubocop:disable Metrics/MethodLength
+  # rubocop:disable Metrics/AbcSize
+  # rubocop:disable Metrics/CyclomaticComplexity
+  # rubocop:disable Metrics/PerceivedComplexity


Lint/UnneededCopDisableDirective: Unnecessary disabling of Metrics/PerceivedComplexity.

houndci-bot · 2018-07-26T12:19:21Z

2358/2/index.rb

+
+  # rubocop:disable Metrics/MethodLength
+  # rubocop:disable Metrics/AbcSize
+  # rubocop:disable Metrics/CyclomaticComplexity


Lint/UnneededCopDisableDirective: Unnecessary disabling of Metrics/CyclomaticComplexity.

houndci-bot · 2018-07-26T12:19:22Z

2358/2/index.rb

+  private
+
+  # rubocop:disable Metrics/MethodLength
+  # rubocop:disable Metrics/AbcSize


Lint/UnneededCopDisableDirective: Unnecessary disabling of Metrics/AbcSize.

houndci-bot · 2018-07-26T12:19:22Z

2358/2/index.rb

+
+  private
+
+  # rubocop:disable Metrics/MethodLength


Lint/UnneededCopDisableDirective: Unnecessary disabling of Metrics/MethodLength.

houndci-bot · 2018-07-26T12:19:22Z

2358/2/constants.rb

+# :reek:NilCheck
+TEXTS_PATH = "#{Dir.pwd}/texts".freeze
+
+SHORT_WORDS = %w[в на и я с не ни по под от у ты что Я И ТЫ как это Но - тебя но меня он А мне за все бы был кто так же его то Это тебе Ты а про вы мой Он тут Что  из есть у здесь нет Как к Если Не там даже Вы для Ты ф про вы мой Он тут Что из у Как к Не там Вы где для  В до всё мы или – У То *** раз Вот Мы еще со их Ну о без].freeze


Metrics/LineLength: Line is too long. [335/120]
Layout/SpaceInsideArrayPercentLiteral: Use only a single space inside array percent literal.

houndci-bot · 2018-07-26T21:30:44Z

2358/2/index.rb

+      end
+    else
+      puts "Рэпер #{@name} не известен мне. Зато мне известны:"
+      RAPPER_NAMES.keys.shuffle.first(5).each do |name|


Performance/Sample: Use sample(5) instead of shuffle.first(5).

houndci-bot · 2018-07-26T21:30:44Z

2358/2/index.rb

+ # :reek:TooManyStatements
+  def show_favorite_word
+    if RAPPER_NAMES[@name]
+      counter_array = (@words_counter[@name] - SHORT_WORDS).group_by { |name| name }.map { |name, counter| [name, counter.count] }


Metrics/LineLength: Line is too long. [130/120]

houndci-bot · 2018-07-26T21:30:45Z

2358/2/index.rb

+  end
+
+ # :reek:TooManyStatements
+  def show_favorite_word


Metrics/AbcSize: Assignment Branch Condition size for show_favorite_word is too high. [20.12/15]
Metrics/MethodLength: Method has too many lines. [12/10]

houndci-bot · 2018-07-26T21:30:45Z

2358/2/index.rb

+    puts table
+  end
+
+ # :reek:TooManyStatements


Layout/CommentIndentation: Incorrect indentation detected (column 1 instead of 2).

houndci-bot · 2018-07-26T21:30:45Z

2358/2/index.rb

+  end
+
+  # :reek:TooManyStatements
+  def show_table


Metrics/MethodLength: Method has too many lines. [15/10]

houndci-bot · 2018-07-26T21:30:45Z

2358/2/index.rb

+  # :reek:TooManyStatements
+  # :reek:NilCheck
+  # :reek:NestedIterators
+  def calculation


Metrics/AbcSize: Assignment Branch Condition size for calculation is too high. [43.65/15]
Metrics/CyclomaticComplexity: Cyclomatic complexity for calculation is too high. [8/6]
Metrics/MethodLength: Method has too many lines. [36/10]
Metrics/PerceivedComplexity: Perceived complexity for calculation is too high. [12/7]

houndci-bot · 2018-07-26T21:30:45Z

2358/2/index.rb

+    @name = name
+  end
+# :reek:NilCheck
+  def show_result


Layout/EmptyLineBetweenDefs: Use empty lines between method definitions.

houndci-bot · 2018-07-26T21:30:45Z

2358/2/index.rb

+    @top = top
+    @name = name
+  end
+# :reek:NilCheck


Layout/CommentIndentation: Incorrect indentation detected (column 0 instead of 2).

houndci-bot · 2018-07-26T21:32:21Z

2358/2/index.rb

+  end
+
+ # :reek:TooManyStatements
+  def show_favorite_word


Metrics/AbcSize: Assignment Branch Condition size for show_favorite_word is too high. [19.13/15]
Metrics/MethodLength: Method has too many lines. [12/10]

houndci-bot · 2018-07-26T22:16:15Z

2358/2/index.rb

+  # rubocop:disable Metrics/AbcSize
+  # rubocop:disable Layout/CommentIndentation
+  # :reek:TooManyStatements
+  def show_favorite_word


Layout/EmptyLineBetweenDefs: Use empty lines between method definitions.

houndci-bot · 2018-07-26T22:16:15Z

2358/2/index.rb

+  # rubocop:disable Metrics/MethodLength
+  # rubocop:disable Metrics/LineLength
+  # rubocop:disable Metrics/AbcSize
+  # rubocop:disable Layout/CommentIndentation


Lint/UnneededCopDisableDirective: Unnecessary disabling of Layout/CommentIndentation.

houndci-bot · 2018-07-26T22:16:15Z

2358/2/index.rb

+    )
+    puts table
+  end
+  # rubocop:disable Metrics/MethodLength


Lint/UnneededCopDisableDirective: Unnecessary disabling of Metrics/MethodLength.

houndci-bot · 2018-07-26T22:16:15Z

2358/2/index.rb

+  end
+  # rubocop:enable Layout/EmptyLineBetweenDefs
+  # rubocop:enable Layout/CommentIndentation
+  private


Layout/EmptyLinesAroundAccessModifier: Keep a blank line before and after private.

houndci-bot · 2018-07-26T22:16:15Z

2358/2/index.rb

+    @top = top
+    @name = name
+  end
+  # rubocop:disable Layout/CommentIndentation


Lint/UnneededCopDisableDirective: Unnecessary disabling of Layout/CommentIndentation.

houndci-bot · 2018-07-26T22:37:19Z

2358/2/index.rb

+  # rubocop:enable Metrics/MethodLength
+  # rubocop:enable Metrics/LineLength
+  # rubocop:enable Metrics/AbcSize
+  # rubocop:enable Layout/CommentIndentation


Lint/UnneededCopEnableDirective: Unnecessary enabling of Layout/CommentIndentation.

houndci-bot · 2018-07-26T22:37:19Z

2358/2/index.rb

+    end
+  end
+  # rubocop:enable Layout/EmptyLineBetweenDefs
+  # rubocop:enable Layout/CommentIndentation


Lint/UnneededCopEnableDirective: Unnecessary enabling of Layout/CommentIndentation.

houndci-bot · 2018-07-26T22:37:20Z

2358/2/index.rb

+  # rubocop:enable Metrics/MethodLength
+  # rubocop:enable Metrics/LineLength
+  # rubocop:enable Metrics/AbcSize
+  # rubocop:enable Layout/CommentIndentation


Lint/UnneededCopEnableDirective: Unnecessary enabling of Layout/CommentIndentation.

houndci-bot · 2018-07-26T22:37:20Z

2358/2/index.rb

+    end
+  end
+  # rubocop:enable Layout/EmptyLineBetweenDefs
+  # rubocop:enable Layout/CommentIndentation


Lint/UnneededCopEnableDirective: Unnecessary enabling of Layout/CommentIndentation.

HolyWalley suggested changes Jul 22, 2018

View reviewed changes

houndci-bot reviewed Jul 24, 2018

View reviewed changes

bigbrother13 changed the title ~~VERSUS parser~~ battle texts handler (level 1) Jul 24, 2018

battle texts handler (level 1)

ae7b257

bigbrother13 changed the title ~~battle texts handler (level 1)~~ 2358-2 Jul 24, 2018

houndci-bot reviewed Jul 25, 2018

View reviewed changes

houndci-bot reviewed Jul 26, 2018

View reviewed changes

Add second level

242169b

+              bad_words_counter = {}
+              words_per_battle_counter = {}
+              words_per_round_counter = {}
+              average_words_per_round_conter = {}

+              require 'russian_obscenity'
+              require 'terminal-table'
+              TEXTS_PATH = '/home/dshop/Vova/word/texts'.freeze

+              RAPPER_NAMES.each do |k, _|
+                words_per_battle_counter[k] = (bad_words_counter[k].to_f / battles_count[k]).round(2)
+                average_words_per_round_conter[k] = words_per_round_counter[k] / (battles_count[k] * 3)


		words_from_text = lines.join.tr("\n", ' ').delete('.,;').split

		bad_words_count = words_from_text.select do \|x\|


		name_from_hash = RAPPER_NAMES.find { \|_, reg\| rapper_name =~ reg }

		next if name_from_hash.nil?

		@@ -0,0 +1,111 @@
		TEXTS_PATH = "#{Dir.pwd}/texts".freeze
		SHORT_WORDS = %w[в на и я с не ни по под от у ты что Я И ТЫ как это Но - тебя но меня он А мне за все бы был кто так же его то Это тебе Ты а про вы мой Он тут Что из есть у здесь нет Как к Если Не там даже Вы для Ты ф про вы мой Он тут Что из у Как к Не там Вы где для В до всё мы или – У То *** раз Вот Мы еще со их Ну о без].freeze

2358-2 #266

Are you sure you want to change the base?

2358-2 #266

Conversation

bigbrother13 commented Jul 21, 2018 • edited Loading

Номер

Номер задания

Ссылка на видео с демо

Комментарии

HolyWalley left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

allomov commented Jul 23, 2018

allomov commented Jul 23, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bigbrother13 commented Jul 21, 2018 •

edited

Loading