2312-3 #289
2312-3 #289
Conversation
2312/3/text_analytics.rb
Outdated
| def json | ||
| JSON.parse request_respond.body | ||
| end | ||
| private |
There was a problem hiding this comment.
Layout/EmptyLinesAroundAccessModifier: Keep a blank line before and after private.
2312/3/text_analytics.rb
Outdated
| @request = request_api.request | ||
| @request_respond = request_api.request_respond | ||
| end | ||
| def json |
There was a problem hiding this comment.
Layout/EmptyLineBetweenDefs: Use empty lines between method definitions.
2312/3/request_api.rb
Outdated
| request.body = data.to_json | ||
| request | ||
| end | ||
| def request_respond |
There was a problem hiding this comment.
Layout/EmptyLineBetweenDefs: Use empty lines between method definitions.
2312/3/request_api.rb
Outdated
| @uri = URI('https://westeurope.api.cognitive.microsoft.com/text/analytics/v2.0/sentiment') | ||
| @request = create_request(data) | ||
| end | ||
| def create_request(data) |
There was a problem hiding this comment.
Layout/EmptyLineBetweenDefs: Use empty lines between method definitions.
2312/3/onliner_parser.rb
Outdated
| def import_json_from_api | ||
| "https://comments.api.onliner.by/news/tech.post/#{search_post_id}/comments?limit=#{COMMENTS_LIMIT}" | ||
| end | ||
| def parse_json |
There was a problem hiding this comment.
Layout/EmptyLineBetweenDefs: Use empty lines between method definitions.
2312/3/stylesheets/pages/_index.scss
Outdated
| -24px 48px 1px #d8d6d5, -25px 50px 1px #dbdad9, | ||
| -26px 52px 1px #dfdddc, -27px 54px 1px #e2e0df, | ||
| -28px 56px 1px #e4e3e2; } | ||
| text-rendering: optimizeLegibility; |
There was a problem hiding this comment.
Expected item on line 24 to appear before line 6. Rule sets should be ordered as follows: @extends, @includes without @content, properties, @includes with @content, nested rule sets
Line should be indented 4 spaces, but was indented 6 spaces
2312/3/stylesheets/pages/_index.scss
Outdated
| -22px 44px 1px #cfcdcd, -23px 46px 1px #d4d2d1, | ||
| -24px 48px 1px #d8d6d5, -25px 50px 1px #dbdad9, | ||
| -26px 52px 1px #dfdddc, -27px 54px 1px #e2e0df, | ||
| -28px 56px 1px #e4e3e2; } |
There was a problem hiding this comment.
Rule declaration should be followed by an empty line
2312/3/stylesheets/pages/_index.scss
Outdated
| h1 { | ||
| color: $black_color; font-size: 5.75em; letter-spacing: .15em; | ||
| font-weight: 400; text-shadow: | ||
| 1px -1px 0 #767676, -1px 2px 1px #737272, |
There was a problem hiding this comment.
Color literals like #e4e3e2 should only be used in variable declarations; they should be referred to via variable everywhere else.
2312/3/stylesheets/pages/_index.scss
Outdated
| margin-bottom: 5em; | ||
| h1 { | ||
| color: $black_color; font-size: 5.75em; letter-spacing: .15em; | ||
| font-weight: 400; text-shadow: |
There was a problem hiding this comment.
Property 'text-shadow' should be placed on own line
Colon after property should be followed by one space
2312/3/stylesheets/pages/_index.scss
Outdated
| .title { | ||
| margin-bottom: 5em; | ||
| h1 { | ||
| color: $black_color; font-size: 5.75em; letter-spacing: .15em; |
There was a problem hiding this comment.
Name of variable black_color should be written in all lowercase letters with hyphens instead of underscores
Property 'font-size' should be placed on own line
Properties should be ordered color, font-size, font-weight, letter-spacing, text-shadow
Property 'letter-spacing' should be placed on own line.15 should be written with a leading zero as 0.15
Номер
2312
Номер задания
3
Ссылка на видео с демо
https://www.youtube.com/watch?v=ebbTNXX9nzs&feature=youtu.be
Комментарии
noop