This repository has been archived by the owner on Jun 27, 2019. It is now read-only.
2264-3 #293
Open
2264-3 #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kislak
reviewed
Aug 8, 2018
| attr_reader :uri, :documents, :request | ||
|
|
||
| def initialize(texts) | ||
| @uri = URI(URL + PATH) |
kislak
reviewed
Aug 8, 2018
|
|
||
| def initialize(texts) | ||
| @uri = URI(URL + PATH) | ||
| build_documents(texts) |
There was a problem hiding this comment.
I should not probably do anything in initializer except for saving input
def initialize(texts)
@texts = texts
end
kislak
reviewed
Aug 8, 2018
| PATH = '/text/analytics/v2.0/sentiment'.freeze | ||
| KEY = 'de8a560ccae541e08ec1a30dcdd191a4'.freeze | ||
|
|
||
| attr_reader :uri, :documents, :request |
There was a problem hiding this comment.
should the class count raiting?
attr_reader should define visible for outside incoming and outgoing params:
I assume it should be texts and ratings
the rest is implementation details - it should be in private section (methods in private sections)
kislak
reviewed
Aug 8, 2018
| end | ||
|
|
||
| def launch_parser | ||
| parse_comments_from_page |
There was a problem hiding this comment.
method should call at least 2 other methods - otherwise U should remove it:
U can just put the body 'parse_comments_from_page' right here
kislak
reviewed
Aug 8, 2018
|
|
||
| def initialize(post) | ||
| @post = post | ||
| @text_body = launch_comments_parser |
There was a problem hiding this comment.
def text_body
@text_body ||= launch_comments_parser
end
seems that text_body doesn't belong to initializer
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Номер
2264
Номер задания
3
Ссылка на видео с демо
https://youtu.be/Uo4Cg1FEdXc
Комментарии
являюсь сторонником минимализма в плане внешнего вида приложения)