Mihail Sokurenko-0 #26

M1ha11 · 2018-12-09T14:25:35Z

Name

Valentine Zavadskiy

Homework#

0

Link to video with demo

https://www.youtube.com/watch?v=ecIWPzGEbFc

Comment

Level 1 and 2.

houndci-bot

Some files could not be reviewed due to errors:

Error: We found some problems with your configuration file: [/IrresponsibleMo...

Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

houndci-bot · 2018-12-09T14:25:57Z

Mihail Sokurenko/0/hw0.rb

+
+s = Price.new
+s.find
+


Layout/TrailingBlankLines: 1 trailing blank lines detected.

houndci-bot · 2018-12-09T14:25:57Z

Mihail Sokurenko/0/hw0.rb

+      puts "For similar price u can buy #{str}" 
+    end
+  end
+


Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body end.

houndci-bot · 2018-12-09T14:25:57Z

Mihail Sokurenko/0/hw0.rb

+      puts"No product with similar price"
+    else 
+      str = a.map{|r| "#{r.capitalize.gsub(/\s+/, " ").gsub(/\n/, " ")}"}.join(', ') 
+      puts "For similar price u can buy #{str}" 


Layout/TrailingWhitespace: Trailing whitespace detected.

houndci-bot · 2018-12-09T14:25:57Z

Mihail Sokurenko/0/hw0.rb

+    if a.empty?
+      puts"No product with similar price"
+    else 
+      str = a.map{|r| "#{r.capitalize.gsub(/\s+/, " ").gsub(/\n/, " ")}"}.join(', ') 


Layout/SpaceBeforeBlockBraces: Space missing to the left of {.
Layout/SpaceInsideBlockBraces: Space between { and | missing.
Style/UnneededInterpolation: Prefer to_s over string interpolation.
Style/StringLiteralsInInterpolation: Prefer single-quoted strings inside interpolations.
Performance/StringReplacement: Use tr instead of gsub.
Layout/SpaceInsideBlockBraces: Space missing inside }.
Layout/TrailingWhitespace: Trailing whitespace detected.

houndci-bot · 2018-12-09T14:25:57Z

Mihail Sokurenko/0/hw0.rb

+  def similar_out(a)
+    if a.empty?
+      puts"No product with similar price"
+    else 


Layout/TrailingWhitespace: Trailing whitespace detected.

houndci-bot · 2018-12-09T14:25:58Z

Mihail Sokurenko/0/hw0.rb

+    @all
+  end
+
+  def out()


Style/DefWithParentheses: Omit the parentheses in defs when the method doesn't accept any arguments.

houndci-bot · 2018-12-09T14:25:59Z

Mihail Sokurenko/0/hw0.rb

+  def all_files
+    Dir.foreach('./date').each do |file|
+      case File.extname(file)
+      when '.xlsx' then 


Layout/TrailingWhitespace: Trailing whitespace detected.

houndci-bot · 2018-12-09T14:25:59Z

Mihail Sokurenko/0/hw0.rb

+
+  def old_price(file)
+    date = get_date(file)
+    if date[1].to_i < 2017


Style/GuardClause: Use a guard clause instead of wrapping the code inside a conditional expression.
Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.

houndci-bot · 2018-12-09T14:25:59Z

Mihail Sokurenko/0/hw0.rb

+  def get_date(file)
+    dates = file.row(3)[0].split(' ')
+    @date.each do |d, t|
+      if dates[1] == d.to_s


Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.

houndci-bot · 2018-12-09T14:25:59Z

Mihail Sokurenko/0/hw0.rb

+    a = []
+    @c.each do |mas|
+      mas.each do |arr|
+        if arr == @pr && mas[0] !~ /#{@name.upcase}[.,) ]{1}/ && mas[0] != @name.upcase && !arr.nil?


Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.

anatoliliotych

Please, re-read https://github.com/rubocop-hq/ruby-style-guide and fix rubocop issues.

houndci-bot

Some files could not be reviewed due to errors:

Error: We found some problems with your configuration file: [/IrresponsibleMo...

Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

houndci-bot · 2018-12-09T19:14:22Z

Mihail Sokurenko/0/hw0.rb

+end
+
+s = Price.new
+s.find


Layout/TrailingBlankLines: Final newline missing.

houndci-bot · 2018-12-09T19:14:22Z

Mihail Sokurenko/0/hw0.rb

+    if a.empty?
+      puts"No product with similar price"
+    else
+      str = a.map { |r| "#{r.to_s.capitalize.gsub(/\s+/, " ")}" }.join(', ')


Style/UnneededInterpolation: Prefer to_s over string interpolation.
Style/StringLiteralsInInterpolation: Prefer single-quoted strings inside interpolations.

houndci-bot · 2018-12-09T19:14:22Z

Mihail Sokurenko/0/hw0.rb

+
+  def old_price(file)
+    date = get_date(file)
+    (true) if date[1].to_i < 2017


Style/RedundantParentheses: Don't use parentheses around a literal.

houndci-bot · 2018-12-09T19:14:22Z

Mihail Sokurenko/0/hw0.rb

+    max_out(max, @max_dat)
+  end
+
+  def similar


Metrics/AbcSize: Assignment Branch Condition size for similar is too high. [15.65/15]

houndci-bot · 2018-12-09T19:14:23Z

Mihail Sokurenko/0/hw0.rb

+        dat = get_date(f)
+        old_price(f) ? coef = 0.0001 : coef = 1
+        f.each_with_index do |_, i|
+          if f.row(i)[0] == @name.upcase || f.row(i)[0] =~ /#{@name.upcase}[.,) ]{1}/


Style/Next: Use next to skip iteration.

houndci-bot · 2018-12-09T19:14:23Z

Mihail Sokurenko/0/hw0.rb

+    out
+  end
+
+  def min


Metrics/AbcSize: Assignment Branch Condition size for min is too high. [28.3/15]
Metrics/CyclomaticComplexity: Cyclomatic complexity for min is too high. [7/6]
Metrics/MethodLength: Method has too many lines. [17/10]

houndci-bot · 2018-12-09T19:14:23Z

Mihail Sokurenko/0/hw0.rb

+    @l = 0
+    @c.each_with_index do |mas, i|
+      mas.each_with_index do |arr, j|
+        if mas[0] != nil && mas[0] == @name.upcase || mas[0] =~ /#{@name.upcase}[.,) ]{1}/


Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Style/NonNilCheck: Prefer !expression.nil? over expression != nil.

houndci-bot · 2018-12-09T19:14:24Z

Mihail Sokurenko/0/hw0.rb

+              'декабрь': '12'}
+  end
+
+  def find


Metrics/AbcSize: Assignment Branch Condition size for find is too high. [16.31/15]
Metrics/MethodLength: Method has too many lines. [12/10]

houndci-bot · 2018-12-09T19:14:24Z

Mihail Sokurenko/0/hw0.rb

+    @date = { 'январь': '01', 'февраль': '02', 'март': '03', 'апрель': '04',
+              'май': '05', 'июнь': '06', 'июль': '07', 'август': '08',
+              'сентябрь': '09', 'октябрь': '10', 'ноябрь': '11',
+              'декабрь': '12'}


Layout/SpaceInsideHashLiteralBraces: Space inside } missing.

houndci-bot · 2018-12-09T19:14:24Z

Mihail Sokurenko/0/hw0.rb

+require 'roo'
+require 'roo-xls'
+
+class Price


Metrics/ClassLength: Class has too many lines. [121/100]

houndci-bot

Some files could not be reviewed due to errors:

Error: We found some problems with your configuration file: [/IrresponsibleMo...

Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

houndci-bot · 2018-12-09T20:13:49Z

Mihail Sokurenko/0/hw0.rb

+    max = @pr
+    all_files
+    @all.each do |f|
+      unless f.nil?


Style/Next: Use next to skip iteration.

houndci-bot · 2018-12-09T20:13:50Z

Mihail Sokurenko/0/hw0.rb

+    min_out(min, @min_dat)
+  end
+
+  def max


Metrics/AbcSize: Assignment Branch Condition size for max is too high. [27.35/15]
Metrics/CyclomaticComplexity: Cyclomatic complexity for max is too high. [7/6]
Metrics/MethodLength: Method has too many lines. [17/10]

houndci-bot · 2018-12-09T20:13:50Z

Mihail Sokurenko/0/hw0.rb

+    min = @pr
+    all_files
+    @all.each do |f|
+      unless f.nil?


Style/Next: Use next to skip iteration.

houndci-bot · 2018-12-09T20:13:50Z

Mihail Sokurenko/0/hw0.rb

+    out
+  end
+
+  def min


Metrics/AbcSize: Assignment Branch Condition size for min is too high. [27.35/15]
Metrics/CyclomaticComplexity: Cyclomatic complexity for min is too high. [7/6]
Metrics/MethodLength: Method has too many lines. [17/10]

houndci-bot · 2018-12-09T20:13:50Z

Mihail Sokurenko/0/hw0.rb

+              'декабрь': '12' }
+  end
+
+  def find


Metrics/AbcSize: Assignment Branch Condition size for find is too high. [17.23/15]

houndci-bot · 2018-12-09T20:13:50Z

Mihail Sokurenko/0/hw0.rb

+require 'roo'
+require 'roo-xls'
+
+class Price


Metrics/ClassLength: Class has too many lines. [117/100]

houndci-bot

Some files could not be reviewed due to errors:

Error: We found some problems with your configuration file: [/IrresponsibleMo...

Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

HW0 initial commit

b431fef

houndci-bot reviewed Dec 9, 2018

View reviewed changes

some fixes

cfa1d30

anatoliliotych self-requested a review December 9, 2018 15:41

M1ha11 changed the title ~~Mihail Sokurenko~~ Mihail Sokurenko-0 Dec 9, 2018

anatoliliotych added the anatoli.liotych label Dec 9, 2018

anatoliliotych requested changes Dec 9, 2018

View reviewed changes

houndci-bot reviewed Dec 9, 2018

View reviewed changes

2nd fixes

db08f0c

houndci-bot reviewed Dec 9, 2018

View reviewed changes

rubocop fix

206506b

houndci-bot reviewed Dec 20, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mihail Sokurenko-0 #26

Mihail Sokurenko-0 #26

M1ha11 commented Dec 9, 2018

houndci-bot left a comment

houndci-bot Dec 9, 2018

houndci-bot Dec 9, 2018

houndci-bot Dec 9, 2018

houndci-bot Dec 9, 2018

houndci-bot Dec 9, 2018

houndci-bot Dec 9, 2018

houndci-bot Dec 9, 2018

houndci-bot Dec 9, 2018

houndci-bot Dec 9, 2018

houndci-bot Dec 9, 2018

anatoliliotych left a comment

houndci-bot left a comment

houndci-bot Dec 9, 2018

houndci-bot Dec 9, 2018

houndci-bot Dec 9, 2018

houndci-bot Dec 9, 2018

houndci-bot Dec 9, 2018

houndci-bot Dec 9, 2018

houndci-bot Dec 9, 2018

houndci-bot Dec 9, 2018

houndci-bot Dec 9, 2018

houndci-bot Dec 9, 2018

houndci-bot left a comment

houndci-bot Dec 9, 2018

houndci-bot Dec 9, 2018

houndci-bot Dec 9, 2018

houndci-bot Dec 9, 2018

houndci-bot Dec 9, 2018

houndci-bot Dec 9, 2018

houndci-bot left a comment

+                  out
+                end
+                def min


		s = Price.new
		s.find

Mihail Sokurenko-0 #26

Are you sure you want to change the base?

Mihail Sokurenko-0 #26

Conversation

M1ha11 commented Dec 9, 2018

Name

Homework#

Link to video with demo

Comment

houndci-bot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anatoliliotych left a comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment