trait system refactor initiative update #1120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcnr
force-pushed
the
trait-system-refactor-update
branch
from
1b59bdd
to
5749a3a
Compare
compiler-errors
approved these changes
Jul 11, 2023
BoxyUwU
approved these changes
Jul 11, 2023
posts/inside-rust/2023-07-11-trait-system-refactor-initiative.md
Outdated
Show resolved
Hide resolved
posts/inside-rust/2023-07-11-trait-system-refactor-initiative.md
Outdated
Show resolved
Hide resolved
CleanCut
reviewed
Jul 11, 2023
posts/inside-rust/2023-07-11-trait-system-refactor-initiative.md
Outdated
Show resolved
Hide resolved
posts/inside-rust/2023-07-11-trait-system-refactor-initiative.md
Outdated
Show resolved
Hide resolved
compiler-errors
approved these changes
Jul 13, 2023
|
alright, would like to merge this tomorrow and changed the date to reflect that. |
jackh726
reviewed
Jul 16, 2023
posts/inside-rust/2023-07-17-trait-system-refactor-initiative.md
Outdated
Show resolved
Hide resolved
posts/inside-rust/2023-07-17-trait-system-refactor-initiative.md
Outdated
Show resolved
Hide resolved
posts/inside-rust/2023-07-17-trait-system-refactor-initiative.md
Outdated
Show resolved
Hide resolved
posts/inside-rust/2023-07-17-trait-system-refactor-initiative.md
Outdated
Show resolved
Hide resolved
posts/inside-rust/2023-07-17-trait-system-refactor-initiative.md
Outdated
Show resolved
Hide resolved
posts/inside-rust/2023-07-17-trait-system-refactor-initiative.md
Outdated
Show resolved
Hide resolved
posts/inside-rust/2023-07-17-trait-system-refactor-initiative.md
Outdated
Show resolved
Hide resolved
|
alright, went through @jackh726 and this is ready for merge again |
marmeladema
reviewed
Jul 17, 2023
posts/inside-rust/2023-07-17-trait-system-refactor-initiative.md
Outdated
Show resolved
Hide resolved
jackh726
reviewed
Jul 18, 2023
posts/inside-rust/2023-07-17-trait-system-refactor-initiative.md
Outdated
Show resolved
Hide resolved
jackh726
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
intend to wait until at least tuesday to look over this myself again and also give some time for the rest of @rust-lang/initiative-trait-system-refactor to have a look. cc @rust-lang/types