Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use screenshot name as-is #39

Merged
merged 3 commits into from
Sep 14, 2023

Conversation

tianfeng92
Copy link
Contributor

@tianfeng92 tianfeng92 commented Sep 12, 2023

@tianfeng92 tianfeng92 marked this pull request as ready for review September 12, 2023 23:01
@tianfeng92 tianfeng92 requested a review from a team as a code owner September 12, 2023 23:01
@tianfeng92 tianfeng92 changed the title chore: Rename screenshot file when collecting attachment chore: Use screenshot name as-is Sep 13, 2023
@mhan83
Copy link
Contributor

mhan83 commented Sep 13, 2023

In the linked job, the screenshots are all the same https://assets.saucelabs.com/jobs/1be160feb1724b5495275fe24365b573/test-finished-1.png

@tianfeng92
Copy link
Contributor Author

In the linked job, the screenshots are all the same https://assets.saucelabs.com/jobs/1be160feb1724b5495275fe24365b573/test-finished-1.png

Yep. Because the screenshot folder structure is like

__assets__/demo-todo-app-Editing-should-save-edits-on-blur-webkit
__assets__/demo-todo-app-Editing-should-save-edits-on-blur-webkit/test-finished-1.png
__assets__/demo-todo-app-Routing-should-allow-me-to-display-all-items-chromium
__assets__/demo-todo-app-Routing-should-allow-me-to-display-all-items-chromium/test-finished-1.png

We're handling those assets flattened. So only test-finished-1.png got uploaded and overwritten. This issue is existing for all frameworks and it'd better to keep the consistency here until platform has the ability to handle nested assets structure. So I reverted the filename composition here and use it as is.

@tianfeng92 tianfeng92 merged commit eb3fe24 into main Sep 14, 2023
3 checks passed
@tianfeng92 tianfeng92 deleted the devx-2408-copy-screenshot-when-collecting-attachment branch September 14, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants