feat: Merge videos generated by playwright into a single mp4 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is, not every test case generated a video
Matches default exemptions of ts compiler.
Co-authored-by: Alex Plischke <[email protected]>
Cleanup tmp dir
alexplischke
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
mergeVideosconfiguration to enable the feature. Defaults to false.Comments
The video timestamps added to the sauce test report are in the order given to the plugin by the reporter api. When displaying the report in the Test Results page, the results are flattened and displayed depth first. The reporter api generates the test report breadth first, that is, it processes a suite's test cases before processing sub suites. The result is the timestamps in the Test Results page are in reverse order:
I've chosen to keep the reporter logic the same and update the front end to flatten breadth first.
Another issue you'll notice in the screenshot above is the ui doesn't render the video timestamp if the value is
0. I'll fix that as well.DEVX-3040