Skip to content
This repository has been archived by the owner on Jul 10, 2023. It is now read-only.

Use foreign types crate #92

Merged
merged 11 commits into from
Oct 2, 2017
Merged

Use foreign types crate #92

merged 11 commits into from
Oct 2, 2017

Conversation

kornelski
Copy link
Contributor

@kornelski kornelski commented Sep 14, 2017

As suggested in #81, changed TCFType boilerplate to foreign-types.


This change is Reviewable

@kornelski
Copy link
Contributor Author

Any comments on this?

@jdm
Copy link
Member

jdm commented Oct 2, 2017

This looks like a nice improvement. Thanks!
@bors-servo: r+

@bors-servo
Copy link

📌 Commit a7e05d2 has been approved by jdm

@bors-servo
Copy link

⌛ Testing commit a7e05d2 with merge bfdd5ab...

bors-servo pushed a commit that referenced this pull request Oct 2, 2017
Use foreign types crate

As suggested in #81, changed TCFType boilerplate to foreign-types.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-graphics-rs/92)
<!-- Reviewable:end -->
@bors-servo
Copy link

☀️ Test successful - status-travis
Approved by: jdm
Pushing bfdd5ab to master...

@bors-servo bors-servo merged commit a7e05d2 into servo:master Oct 2, 2017
@kornelski kornelski deleted the foreign-types branch October 2, 2017 17:52
@nox
Copy link
Contributor

nox commented Nov 20, 2017

So now that this landed, what happens to previous wrap_under_get_rule calls…?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants