Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encode space to '%20' as per url standard #928

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

encode space to '%20' as per url standard #928

wants to merge 2 commits into from

Commits on Apr 30, 2024

  1. encode space to '%20' as per url standard 

    Previously the space character was exclusively encoded to '+'. This is
wrong, as the URL Standard [0] specifies that the default is '%20'.
Another function has been introduced as well, which replicates the old
behavior and converts spaces to '+'.
Notice that this breaks the default behavior and could lead to bugs.

[0]: https://url.spec.whatwg.org/#string-percent-encode-after-encoding

Fixes: servo#927
Fixes: servo#888

Signed-off-by: Gabriel Goller <[email protected]>
    @kaffarell
    kaffarell committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    c23893a View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. fix docs link 

    Fixed link to url spec.

Signed-off-by: Gabriel Goller <[email protected]>
    @kaffarell
    kaffarell committed May 2, 2024
    Configuration menu
    Copy the full SHA
    4e3f1b5 View commit details
    Browse the repository at this point in the history