Fix bugs haha.

socketry · Oct 13, 2024 · 8a365c1 · 8a365c1
1 parent 7db82cb
commit 8a365c1
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 14 deletions.
diff --git a/config/sus.rb b/config/sus.rb
@@ -5,3 +5,5 @@
 
 require "covered/sus"
 include Covered::Sus
+
+ENV["TRACES_BACKEND"] ||= "traces/backend/test"
diff --git a/lib/async/pool/controller.rb b/lib/async/pool/controller.rb
@@ -390,11 +390,9 @@ def acquire_or_create_resource
 				def create_resource(...)
 					attributes = {
 						concurrency: @guard.limit,
-						size: @resources.size,
-						limit: @limit,
 					}
 
-					@attributes.merge!(@tags) if @tags
+					attributes.merge!(@tags) if @tags
 
 					Traces.trace('async.pool.create', attributes: attributes) {super}
 				end
@@ -404,44 +402,38 @@ def drain(...)
 						size: @resources.size,
 					}
 
-					@attributes.merge!(@tags) if @tags
+					attributes.merge!(@tags) if @tags
 
 					Traces.trace('async.pool.drain', attributes: attributes) {super}
 				end
 
 				def acquire(...)
 					attributes = {
-						concurrency: @guard.limit,
 						size: @resources.size,
 						limit: @limit,
 					}
 
-					@attributes.merge!(@tags) if @tags
+					attributes.merge!(@tags) if @tags
 
 					Traces.trace('async.pool.acquire', attributes: attributes) {super}
 				end
 
 				def release(...)
 					attributes = {
-						concurrency: @guard.limit,
 						size: @resources.size,
-						limit: @limit,
 					}
 
-					@attributes.merge!(@tags) if @tags
+					attributes.merge!(@tags) if @tags
 
 					Traces.trace('async.pool.release', attributes: attributes) {super}
 				end
 
 				def retire(...)
 					attributes = {
-						concurrency: @guard.limit,
 						size: @resources.size,
-						limit: @limit,
-						**@tags,
 					}
 
-					@attributes.merge!(@tags) if @tags
+					attributes.merge!(@tags) if @tags
 
 					Traces.trace('async.pool.retire', attributes: attributes) {super}
 				end

diff --git a/test/async/pool/controller.rb b/test/async/pool/controller.rb
@@ -50,7 +50,7 @@
 		let(:pool) {subject.new(Async::Pool::Resource, tags: {a: 1, b: 2})}
 
 		it "can assign tags to the pool" do
-			expect(pool.tags).to be == ["a:1", "b:2"]
+			expect(pool.tags).to be == {a: 1, b: 2}
 		end
 	end