Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix disableCaptureURLS #873

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

fix disableCaptureURLS #873

wants to merge 9 commits into from

Conversation

ziaratban
Copy link
Contributor

@ziaratban
Copy link
Contributor Author

I don't know if this bug is related to the last issue in browsershot or not, but I fixed this bug for BC.

@JeppeKnockaert JeppeKnockaert mentioned this pull request Aug 16, 2024
Closed
@freekmurze
Copy link
Member

Could you rebase against main?

@freekmurze
Copy link
Member

Seems like the tests are failing. Could you maybe rebase against main again?

@freekmurze
Copy link
Member

Seems like there are still some conflicts...

CleanShot 2024-08-26 at 06 51 56@2x

@ziaratban
Copy link
Contributor Author

image
🤔🤔🤔

@ziaratban
Copy link
Contributor Author

is everything ok?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ziaratban @freekmurze @JeppeKnockaert