Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Snowflake (#5500) #5502

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support Snowflake (#5500) #5502

wants to merge 1 commit into from

Conversation

turb
Copy link
Contributor

@turb turb commented Sep 25, 2024

First draft of SnowflakeIO for scio, using the one from Beam.

It has:

  • SnowflakeSelect (read only), allowing to read from a select
  • SnowflakeTable (rw), allowing to read or write from/to a table
  • ScioContext and SCollection implicits

Notes:

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 49 lines in your changes missing coverage. Please review.

Project coverage is 61.13%. Comparing base (14c7077) to head (901625d).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...scala/com/spotify/scio/snowflake/SnowflakeIO.scala 0.00% 37 Missing ⚠️
...tify/scio/snowflake/syntax/SCollectionSyntax.scala 0.00% 10 Missing ⚠️
...tify/scio/snowflake/syntax/ScioContextSyntax.scala 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5502      +/-   ##
==========================================
- Coverage   61.41%   61.13%   -0.28%     
==========================================
  Files         312      315       +3     
  Lines       11106    11155      +49     
  Branches      771      764       -7     
==========================================
- Hits         6821     6820       -1     
- Misses       4285     4335      +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@turb turb force-pushed the snowflake branch 2 times, most recently from d179ff2 to 9f6010d Compare September 25, 2024 16:37
@turb
Copy link
Contributor Author

turb commented Sep 25, 2024

The build wants me to have "com.nrinaudo" %% "kantan.csv" % kantanCsvVersion as a runtime dep, but then it cannot compile. I thought that a compile dep was also supposed to be in runtime (at least in the Maven model).

@turb turb force-pushed the snowflake branch 3 times, most recently from 8c434ed to 74d15ae Compare October 16, 2024 12:11
@turb
Copy link
Contributor Author

turb commented Oct 16, 2024

@RustedBones I finally had the time to fix this build :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant