PR: Show banner when the kernel is ready (IPython console) #22501
+49
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dalthviz, could you check that this works on Windows? For that you need to alternate between opening a console for the default env and a different one at least ten times. |
dalthviz
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Thanks @ccordoba12 ! Checked locally on Windows and I was unable to reproduce the issue (showing the consoles banner follows the preference)
Also, maybe some sort of test should be added to check this behavior (creating a new console follows the preference to show or not the initial banner)?
Anyhow, leaving this approved 👍
That's a good idea @dalthviz! I'll add one later today. |
- That helps us to understand when a race condition can happen between those actions. - Also, add log message when setting a Matplotlib backend in MatplotlibStatus widget.
The previous approach didn't work all the time because when the first prompt is shown, the kernel comm is not necessarily connected (and we need that to get the banner info).
Also, add missing end of line to short banner.
ccordoba12
force-pushed
the
issue-22440
branch
from
011bf67
to
a4f357c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Issue(s) Resolved
Fixes #22440.
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @ccordoba12