Pass the correct burnchain tip to run_sign_v0 instead of the block election snapshot #5307
+182
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacinta Ferrant <[email protected]>
hstove
reviewed
Oct 12, 2024
hstove
reviewed
Oct 12, 2024
… into fix/tenure-extend-burnchain-tip-check
…b.com/stacks-network/stacks-core into fix/tenure-extend-burnchain-tip-check
Signed-off-by: Jacinta Ferrant <[email protected]>
…lock snapshot Signed-off-by: Jacinta Ferrant <[email protected]>
jferrant
changed the title
… into fix/tenure-extend-burnchain-tip-check
obycode
reviewed
Oct 17, 2024
Signed-off-by: Jacinta Ferrant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tenure extends were not being properly handled as the burnchain tip was not actually being passed through the run_sign_v0 function. Rather it was using the block election snapshot because block.header.consensus_hash is the consensus hash of the election snapshot.