Skip to content

Commit

Permalink
Raise minimum Go version to 1.21 (#355)
Browse files Browse the repository at this point in the history
There have apparently been some bug fixes related to generics in recent
releases. This causes problems when using Gofish with older Go releases
where it does not like the contraints defined on some of the recent
updates using generics. This raises our minimum to 1.21 as this is a
version known to work.

While I would have liked to keep the minimum version older to give more
flexibility to library consumers, there are multiple good reasons to
update to the newer release. I do feel bad about the very short notice
though.

Signed-off-by: Sean McGinnis <[email protected]>
  • Loading branch information
stmcginnis authored Jul 10, 2024
1 parent a9703ef commit 1758adc
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v5
with:
go-version: '1.22.0'
go-version: '1.21'

# Build the code
- name: Run build
Expand All @@ -39,7 +39,7 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v5
with:
go-version: '1.22.0'
go-version: '1.21'

- name: Run golangci-lint
uses: golangci/golangci-lint-action@v6
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module github.com/stmcginnis/gofish

go 1.18
go 1.21

0 comments on commit 1758adc

Please sign in to comment.