Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Memory Struct (NonVolatileSizeLimitMiB) #360

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Change Memory Struct (NonVolatileSizeLimitMiB) #360

merged 1 commit into from
Sep 3, 2024

Conversation

DeathwingTheBoss
Copy link
Contributor

@DeathwingTheBoss DeathwingTheBoss commented Sep 2, 2024 •
edited
Loading

Since Redfish DMTF Data Spec 2022.2 the Memory field NonVolatileSizeLimitMiB is supposed to be type integer but Gofish has it as string resulting in unmarshalling errors.

This fixes that.

(Had a problem locally, wanted to help upstream in case someone runs into the same issue eventually)

stmcginnis
stmcginnis approved these changes Sep 3, 2024
View reviewed changes
Copy link
Owner

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stmcginnis stmcginnis merged commit 934e39a into stmcginnis:main Sep 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmcginnis stmcginnis stmcginnis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DeathwingTheBoss @stmcginnis