Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flake8 fixes #21

Closed
wants to merge 2 commits into from
Closed

Flake8 fixes #21

wants to merge 2 commits into from

Conversation

sourabhaa
Copy link
Contributor

Fixes #16.

Copy link
Member

@srevinsaju srevinsaju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A rebase would be nice

@sourabhaa
Copy link
Contributor Author

sourabhaa commented Apr 6, 2021

The branch is up to date. I'm not sure why the previous commits to master branch showed up. This also happened in #20. Any suggestions to resolve?

@sourabhaa
Copy link
Contributor Author

Since the branch is up to date with the master, I think squash and merge would work fine.

@chimosky
Copy link
Member

chimosky commented Apr 9, 2021

The branch is up to date. I'm not sure why the previous commits to master branch showed up. This also happened in #20. Any suggestions to resolve?

Sure, an interactive rebase dropping both commits would do the trick. Already mentioned this in #20.
Also drop the merge commit ba39ea4 as it makes it difficult to view the diff when using a diff tool.

Since the branch is up to date with the master, I think squash and merge would work fine.

Can you squash the commits and push here? Let me know if you need any help.

@sourabhaa
Copy link
Contributor Author

Can you squash the commits and push here? Let me know if you need any help.

Done as you suggested. @chimosky kindly review.

@chimosky
Copy link
Member

Reviewed, thanks. Merged by hand as bd72848.

Some comments;

Some of the imports can occupy the same line, if you want to ignore some errors you can add them to .flake8 in the format

[flake8]
ignore = F405

You can search our repos for these files and you'll see others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flake8 opportunities
3 participants