Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support source and declaration maps in package #11527

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JanNitschke
Copy link

@JanNitschke JanNitschke commented Jan 5, 2024

Allows svelte-package to generate source and declaration maps from typescript and preprocessors. Updates the relative source paths of these maps when they are moved around during the build process.

closes #7793
closes #7792

#8843 fixes declaration maps paths when they are created.
My approach updates the path when files are copied, so it works with maps from any source.

This PR also generates .svelte.map files containing source maps for transformed svelte files, but I have not found a way to reference them from the generated .svelte file (see javascripts //# sourceMappingURL).

Svelte source maps are created based on compilerOptions.enableSourcemap in svelte.config.js which is true by default.

Typescript source maps and declaration maps respect the settings in tsconfig.json. This is different from declarations which are configured with the -t/--types flag. So maybe this should be changed.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Jan 5, 2024

🦋 Changeset detected

Latest commit: 7111a01

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/package Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

declarationMap option in svelte-package svelte-package doesn't include source maps
1 participant