Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: "Cannot access uninitialized variable" in Safari when using "$env/dynamic/public" #11531

Closed

Conversation

bfanger
Copy link
Contributor

@bfanger bfanger commented Jan 7, 2024

Fixes #11364

Using global await is causing issues in Safari: https://bugs.webkit.org/show_bug.cgi?id=242740.
This bug was introduced in 9439190

This PR removes a fallback, but I'm not sure when the global variable is available but the env property is null or undefined.
So this PR might re-introduce a bug, but that is probably less common bug than trying to use "$env/dynamic/public" on sites that need to support iOS.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Jan 7, 2024

🦋 Changeset detected

Latest commit: e6405da

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bfanger
Copy link
Contributor Author

bfanger commented Jan 7, 2024

Diving deeper into the change I see the env: ${!client.uses_env_dynamic_public || state.prerendering ? null : s(public_env)}

Closing the PR as it would break prerenderd pages and a quick fix is not obvoius.
( It's hard to synchronously & conditionally import the environment variables without using global await )

Work in progress bfanger/kit: fix/sveltekit-v2-safari

@bfanger bfanger closed this Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant