Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add load function to handle hook to control css loading #12677

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sviripa
Copy link

@sviripa sviripa commented Sep 15, 2024

This PR introduces an additional handle hook function, similar to preload. The purpose of this function is to control which CSS assets should be loaded for a specific page or route.

This functionality is necessary for dynamic component use case implemented using a combination of +page.server.js and +page.js. In the current version of SvelteKit, the CSS assets of all dynamically imported components are loaded on the page, regardless of whether or not they are actually used.

It is possible to remove unwanted css by redacting the html output using transformPageChunk but this feels more like a hack. It also does not work with inlineStyleThreshold configuration property.

The new function will allow SvelteKit users who use dynamic component imports to control which CSS assets should be loaded.

I'll address the items in the list below once I receive initial feedback on the solution. Thanks 🙏🏻

TODO:

  • Naming
  • Test
  • Docs
  • Changeset

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

P.S.

Huge thank you to everyone involved in Svelte and SvelteKit projects ❤️

Copy link

changeset-bot bot commented Sep 15, 2024

⚠️ No Changeset found

Latest commit: 9230536

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sviripa sviripa changed the title feat: add load function to handle hook to control css loading feat: add load function to handle hook to control css loading Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant