Unicode and DNA regexes + more benchmarker improvements #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
milseman
approved these changes
Jun 27, 2022
| @@ -6,7 +6,7 @@ extension BenchmarkRunner { | |||
| let r = #"--([a-zA-Z0-9_-]+)\s*:\s*(.*?);"# | |||
|
|
|||
| let css = CrossBenchmark( | |||
| baseName: "css", regex: r, input: Inputs.swiftOrgCSS) | |||
| baseName: "Css", regex: r, input: Inputs.swiftOrgCSS) | |||
There was a problem hiding this comment.
FWIW, I believe Swift's naming convention would prefer to keep them all capitalized or all lower case. Not a big deal to me.
|
|
||
| 3. Neither the name "The Computer Language Benchmarks Game" nor the name "The Benchmarks Game" nor the name "The Computer Language Shootout Benchmarks" nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission. | ||
|
|
||
| THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.""" |
There was a problem hiding this comment.
@stephentyrone Can you check off on licensing here?
There was a problem hiding this comment.
I took the script from here https://benchmarksgame-team.pages.debian.net/benchmarksgame/program/fasta-python3-1.html and copied over the license from the repo here https://salsa.debian.org/benchmarksgame-team/benchmarksgame/-/blob/master/LICENSE.md
Not sure if the "redistributions of source code" applies only to the code in the repo for the website/benchmarking harness or for the scripts that users submit as well
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
firstMatchbenchmarks by default because they were running too quickly and not providing information thematchesbenchmarks weren't