Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small comment hiccup #1517

Merged
merged 1 commit into from
May 28, 2024
Merged

Fix small comment hiccup #1517

merged 1 commit into from
May 28, 2024

Conversation

Nispeon
Copy link
Contributor

@Nispeon Nispeon commented Apr 29, 2024

Hello, I opened this tiny PR because I noticed this little error in a comment.

Despite the size, I think it's a rather confusing error, because not knowing how locales work myself, I am not sure whether it was an or no that I should remove to fix the comment.

Hopefully I got it right 🙏🏽

Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@javiereguiluz
Copy link
Member

Good catch, thanks Julien.

@javiereguiluz javiereguiluz merged commit effa75f into symfony:main May 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants