Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate APP_SECRET in .env.local when missing #1531

Closed
wants to merge 1 commit into from

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Sep 30, 2024

The demo app needs an APP_SECRET because it uses ESI, fragments and remember-me, which all need a secret.

Instead of hardcoding a secret in .env, I propose here to generate one in .env.local on composer i/u when it's missing.

Inspired by the discussion on #1529 (comment)

@javiereguiluz
Copy link
Member

This proposal is smart, but I think it's convoluted for the Demo application. Also, it introduces a new "moving part" that could fail.

Is it really wrong to ship this Demo application with a predefined value in APP_SECRET as we've done since day one?

@nicolas-grekas
Copy link
Member Author

Closing in favor of #1532

@nicolas-grekas nicolas-grekas deleted the generate-secret branch October 1, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants