Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ft ipynb support #181

Merged
merged 14 commits into from
Jan 26, 2024
Merged

Ft ipynb support #181

merged 14 commits into from
Jan 26, 2024

Conversation

clemens-fricke
Copy link
Member

Add support for jupyter notebooks.

Base automatically changed from ft-vedo-only to main January 24, 2024 10:15
Copy link
Member

@j042 j042 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks! Some comments below

gustaf/helpers/notebook.py Outdated Show resolved Hide resolved
gustaf/helpers/notebook.py Show resolved Hide resolved
gustaf/helpers/notebook.py Show resolved Hide resolved
gustaf/helpers/notebook.py Outdated Show resolved Hide resolved
gustaf/show.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
gustaf/helpers/notebook.py Outdated Show resolved Hide resolved
gustaf/show.py Outdated Show resolved Hide resolved
@clemens-fricke
Copy link
Member Author

The changes look good. Thank you for the changes.

Copy link
Member

@j042 j042 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thank you so much!

@j042
Copy link
Member

j042 commented Jan 26, 2024

I will bump the version after this

@j042 j042 merged commit 38bd4d5 into main Jan 26, 2024
15 checks passed
@j042 j042 deleted the ft-ipynb-support branch January 26, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants