Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis-ci: added support for ppc64le #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sanjaymsh
Copy link

Hi,
I have added support for ppc64le build on travis-ci in the branch . The travis-ci build log can be tracked on the link :https://travis-ci.com/github/sanjaymsh/java-string-similarity/builds/191872664 . I believe it is ready for the final review and merge.
Please have a look on it.

Thanks !!

@paulirwin
Copy link
Contributor

There is no native code in this library, and therefore if there are CPU architecture differences at runtime that would be a JVM bug. Doesn't seem like there needs to be different architecture builds/tests, or else we should include all kinds of other architectures like ARM. Or am I missing something?

@tdebatty
Copy link
Owner

Hi @paulirwin ! Thank you for this very quick comment!
Indeed, I don't think adding specific ppc64le tests makes sense.
@sanjaymsh : Is there a real case for this? A bug you encountered?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants