Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 503 and retry #108

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sethterashima
Copy link
Collaborator

Description

Please include a summary of the changes and the related issue.

Fixes # (issue)

Type of change

Please select all options that apply to this change:

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

Checklist:

Confirm you have completed the following steps:

  • My code follows the style of this project.
  • I have performed a self-review of my code.
  • I have made corresponding updates to the documentation.
  • I have added/updated unit tests to cover my changes.

Fixes the dispatcher retransmission logic so that the dispatcher
remembers if one of its attempts might have succeeded (even if it never
received a response from the vehicle).

Categorizes an HTTP 503 code as a possible success, since the server may
return this status code if it relays a command to a vehicle but does not
hear back.
@sethterashima sethterashima force-pushed the fix-503-and-retry branch 2 times, most recently from fcad171 to 87bb114 Compare March 18, 2024 18:47
The OpenTrunk method was implemented as an alias for ActuateTrunk, but
the commands have different meanings in vehicles with powered trunks and
vehicles without. The implementations are now correct, and the proxied
`actuate_trunk` invokes ActuateTrunk, leaving its behavior unchanged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant