Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FwbCard: Removed hover on non-links cards #321

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andreyjamer
Copy link
Contributor

@andreyjamer andreyjamer commented Sep 6, 2024

Current implementation of card has hover effect for the case when the card is not a link.
And on the other hand it does not have hover effect for the case when the card contains image and has a link.
This PR fixes this behavior

Summary by CodeRabbit

  • New Features

    • Introduced an optional href property to enhance the card component's functionality, allowing for hyperlinking capabilities.
    • Improved hover effects on the card component based on the presence of the href property, enhancing user interaction.
  • Refactor

    • Updated the logic for generating class strings in the card component to accommodate the new href property and improve responsiveness.

Copy link

coderabbitai bot commented Sep 6, 2024

Walkthrough

The changes introduce an optional href property to the UseCardsClassesProps type in the useCardClasses.ts file. This modification allows the useCardsClasses function to dynamically generate class strings based on the variant and the presence of the href, enhancing the component's styling capabilities.

Changes

Files Change Summary
src/components/FwbCard/composables/useCardClasses.ts Added an optional href property to UseCardsClassesProps and refactored useCardsClasses to conditionally build class strings based on variant and href.

Poem

In a meadow bright, with a hop and a cheer,
A card now links, oh so near!
With classes that dance, and styles that play,
A new href shines, brightening the day.
So let’s leap and bound, with joy we’ll say,
"Hooray for the changes, hip-hip-hooray!" 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Sep 6, 2024

Deploy Preview for sensational-seahorse-8635f8 ready!

Name Link
🔨 Latest commit 43db9b0
🔍 Latest deploy log https://app.netlify.com/sites/sensational-seahorse-8635f8/deploys/66daadf8492a6300084bf64f
😎 Deploy Preview https://deploy-preview-321--sensational-seahorse-8635f8.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c679aa9 and 2c486c2.

Files selected for processing (1)
  • src/components/FwbCard/composables/useCardClasses.ts (1 hunks)
Additional comments not posted (1)
src/components/FwbCard/composables/useCardClasses.ts (1)

6-6: Addition of href property approved.

The addition of the optional href property to UseCardsClassesProps is well-implemented and aligns with the PR's objective to conditionally apply hover effects based on the presence of a link.

src/components/FwbCard/composables/useCardClasses.ts Outdated Show resolved Hide resolved
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2c486c2 and 43db9b0.

Files selected for processing (1)
  • src/components/FwbCard/composables/useCardClasses.ts (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • src/components/FwbCard/composables/useCardClasses.ts

@Sqrcz Sqrcz self-assigned this Sep 6, 2024
@Sqrcz Sqrcz added the 🔧 enhancement New feature or request label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants