Skip to content

Commit

Permalink
Merge pull request #379 from tidev/fix/xcframework-modules
Browse files Browse the repository at this point in the history
  • Loading branch information
cb1kenobi authored May 20, 2023
2 parents 3bbf1d8 + 256d326 commit 6e9eae7
Show file tree
Hide file tree
Showing 6 changed files with 20 additions and 11 deletions.
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,13 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

---

## [7.0.5] - 2023-05-20

### Fixed

- iOS: Do not hard-crash build if framework is missing module map (just skip it)
- CLI: Update Babel

## [6.0.0] - 2020-09-21

### Fixed
Expand Down
10 changes: 5 additions & 5 deletions build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ onexit () {

trap onexit 0 1 2 3 6 9 15

TISDK_SEMVER=">=7.0.0"
TISDK_SEMVER=">=9.2.0"
CHECK=""

# Make sure the Android SDK is installed
Expand All @@ -30,17 +30,17 @@ then
export ANDROID_SDK=~/Library/Android/sdk
else
echo "Please set ANDROID_SDK environment variable and try again"
echo "Download Android SDK from http://developer.android.com/sdk/index.html"
echo "Download Android Studio from https://developer.android.com/studio"
exit 1
fi
echo "$CHECK Android SDK is $ANDROID_SDK"
fi

# Make sure we have at least the Android 7.1 (SDK 25) installed
if [ ! -d "$ANDROID_SDK/platforms/android-25" ];
if [ ! -d "$ANDROID_SDK/platforms/android-33" ];
then
echo "Android 7.1 (Lollipop) / (android-25) not installed"
echo "Download Android 7.1 using Android Studio"
echo "Android 13 (Tiramisu) / (android-33) not installed"
echo "Download the Android 13 SDK using Android Studio"
exit 1
fi

Expand Down
4 changes: 2 additions & 2 deletions iphone/hyperloop.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,7 @@
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_OBJC_BRIDGING_HEADER = "tests/Tests-Bridging-Header.h";
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
SWIFT_VERSION = 3.0;
SWIFT_VERSION = 5.0;
};
name = Debug;
};
Expand All @@ -449,7 +449,7 @@
PRODUCT_BUNDLE_IDENTIFIER = com.appcelerator.hyperloop.tests;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_OBJC_BRIDGING_HEADER = "tests/Tests-Bridging-Header.h";
SWIFT_VERSION = 3.0;
SWIFT_VERSION = 5.0;
};
name = Release;
};
Expand Down
2 changes: 1 addition & 1 deletion iphone/manifest
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
#
version: VERSION
apiversion: 2
architectures: armv7 arm64 i386 x86_64
architectures: arm64 x86_64
description: hyperloop
author: Appcelerator
license: Appcelerator Commercial License
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion packages/hyperloop-ios-metabase/lib/metabase.js
Original file line number Diff line number Diff line change
Expand Up @@ -617,9 +617,11 @@ function generateFrameworkIncludeMap (frameworkMetadata, includes, callback) {

util.logger.trace('Generating includes for ' + frameworkMetadata.type + ' framework ' + frameworkName.green + ' (' + frameworkPath + ')');
if (frameworkMetadata.type === 'dynamic') {
// Skip if we don't have a "Modules" folder
var modulesPath = path.join(frameworkPath, 'Modules');
if (!fs.existsSync(modulesPath)) {
return callback(new Error(`Modules directory for ${frameworkName} not found at expected path ${modulesPath}.`));
includes[frameworkName] = {};
return callback();
}

var moduleMapPathAndFilename = path.join(modulesPath, 'module.modulemap');
Expand Down

0 comments on commit 6e9eae7

Please sign in to comment.