Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Xcode 15 #234

Merged
merged 2 commits into from
Aug 3, 2023
Merged

feat: support Xcode 15 #234

merged 2 commits into from
Aug 3, 2023

Conversation

hansemannn
Copy link
Contributor

No description provided.

@cb1kenobi
Copy link
Contributor

I did some research and found the sim runtimes are now installed as "disk images" in /Library/Developer/CoreSimulator/Images and mounted in /Library/Developer/CoreSimulator/Volumes. Once mounted, Node.js can read files in the mounted volume. The volumes are read only.

I have verified that xcrun simctl list --json will return the runtimes, but I haven't tested this code.

According to https://developer.apple.com/support/xcode/, Xcode 15 supports iOS 17, so we technically don't have to worry about mixing the older sim runtimes with the output from simctl.

FYI, if you unmount the sim runtime image, Xcode does not recover well and I had to delete and redownload/reinstall the runtime. Boo.

While I'm fine with switching to simctl to get the runtimes, I think ioslib@3 will still need to scan the directories. ioslib@3 is still lacking all the simulator start and simulator/device installing. I really need a Mac if I'm going to invest time into ioslib@3.

Stay tuned, will test as soon as I can.

@hansemannn
Copy link
Contributor Author

Very thoughtful feedback, as usual, thank you Chris! Do you think, for Titanium right now, we should go with the solution provided in this branch?

@hansemannn
Copy link
Contributor Author

@cb1kenobi What do we do with this one? :)

Copy link
Contributor

@cb1kenobi cb1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TESTED and APPROVED! Thank you!

@cb1kenobi cb1kenobi merged commit 496ff7f into 1_7_X Aug 3, 2023
@m1ga
Copy link
Contributor

m1ga commented Aug 21, 2023

quick info:

replaceAll is only available starting in node 15. During a user test (see slack) it was producing error. Since we still support node 14 (or not explicitly exclude it) with the current SDK we should use a normal regex instead.

A PR is currently in the making: #235

@cb1kenobi
Copy link
Contributor

Bah, did this PR introduce a regression?

@m1ga
Copy link
Contributor

m1ga commented Aug 21, 2023

yes, users that currently use node 14 won't be able to build apps with 12.2.0 for iOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants