fix: use new provisioning profile directory for lookup #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cb1kenobi Ready for review! :) |
|
@hansemannn cool, will review/test when I get a moment. Thanks! |
cb1kenobi
requested changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the new provisioning profiles directory structure introduces in Xcode 16. Environments that had a previous Xcode installation installed and upgraded to 16 were not affected by this change, but all new / from scratch setups.
For a maximized backwards compatibility, we retain the old directory and use a "smart lookup" from both the old and new directory to ensure we don't miss any profile. Of course, custom directories are still supported as well, although that's not a widely used feature as it seems.
Finally, I changed some false-positive warnings that occurred when you didn't have certain profiles (e.g. adhoc or production), which never made sense, as some developers maybe don't have production or adhoc profiles on their device and don't need them.