remove rest response .asUnit

tim-smart · Feb 16, 2024 · e37d4ab · e37d4ab
1 parent 6348c07
commit e37d4ab
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 16 deletions.
diff --git a/src/DiscordREST.ts b/src/DiscordREST.ts
@@ -256,7 +256,7 @@ const make = Effect.gen(function* (_) {
 })
 
 class RestResponseImpl<T>
-  extends Effectable.Class<ResponseWithData<T>, DiscordRESTError, Scope>
+  extends Effectable.Class<ResponseWithData<T>, DiscordRESTError>
   implements RestResponse<T>
 {
   constructor(
@@ -269,16 +269,16 @@ class RestResponseImpl<T>
     super()
   }
 
-  commit(): Effect.Effect<ResponseWithData<T>, DiscordRESTError, Scope> {
-    return this.response
+  commit(): Effect.Effect<ResponseWithData<T>, DiscordRESTError> {
+    return Effect.scoped(this.response)
   }
 
   get json() {
     return Effect.scoped(Effect.flatMap(this.response, _ => _.json))
   }
 
-  get asUnit() {
-    return Effect.scoped(this.response)
+  get response() {
+    return this.response
   }
 }
 

diff --git a/src/DiscordREST/types.ts b/src/DiscordREST/types.ts
@@ -8,7 +8,7 @@ export interface ResponseWithData<A> extends Http.response.ClientResponse {
 }
 
 export interface RestResponse<T>
-  extends Effect.Effect<ResponseWithData<T>, DiscordRESTError, Scope> {
+  extends Effect.Effect<ResponseWithData<T>, DiscordRESTError> {
   readonly json: Effect.Effect<T, DiscordRESTError | Http.error.ResponseError>
-  readonly asUnit: Effect.Effect<void, DiscordRESTError>
+  readonly response: Effect.Effect<ResponseWithData<T>, DiscordRESTError, Scope>
 }
diff --git a/src/Interactions/gateway.ts b/src/Interactions/gateway.ts
@@ -83,17 +83,15 @@ export const run =
             GlobalApplicationCommand.map(_ => _.command),
           ),
         },
-      ).asUnit
+      )
 
       const guildSync = GuildApplicationCommand.length
-        ? gateway.handleDispatch(
-            "GUILD_CREATE",
-            a =>
-              rest.bulkOverwriteGuildApplicationCommands(
-                application.id,
-                a.id,
-                GuildApplicationCommand.map(_ => _.command) as any,
-              ).asUnit,
+        ? gateway.handleDispatch("GUILD_CREATE", a =>
+            rest.bulkOverwriteGuildApplicationCommands(
+              application.id,
+              a.id,
+              GuildApplicationCommand.map(_ => _.command) as any,
+            ),
           )
         : Effect.never